[webkit-reviews] review granted: [Bug 49086] Incorrect image map used when multiple maps have the same name : [Attachment 73104] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 49086: Incorrect image map used when multiple maps have the same name
https://bugs.webkit.org/show_bug.cgi?id=49086

Attachment 73104: Patch
https://bugs.webkit.org/attachment.cgi?id=73104&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
It seems a little strange that image map names are tracked in the same way as
element IDs, but names in general are handled elsewhere in a very different
manner (see e.g. JSHTMLDocument::nameGetter()). I guess that's fine as long as
we always want the duplicate that's first in document order, but it's still
surprising. Perhaps I don't understand what's so special about map names - why
is there even HTMLMapElement::m_name when the same value is in an attribute,
perhaps lowercased?

The test needs a subtest to make sure that the latest dynamically added map
doesn't get precedence (note that subtest 5 re-adds the first element, so it
doesn't test for that). It also needs an XHTML version, making sure that names
are case sensitive.

Do all tests pass in Firefox?