[webkit-reviews] review denied: [Bug 48964] Linker error, undefined reference WebCore::setsetCookieStoragePrivateBrowsingEnabled(bool) : [Attachment 72957] Moved the Android setCookieStoragePrivateBrowsingEnabled(bool) stub to the WebCore namespace
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 4 10:19:18 PDT 2010
Steve Block <steveblock at google.com> has denied review:
Bug 48964: Linker error, undefined reference
WebCore::setsetCookieStoragePrivateBrowsingEnabled(bool)
https://bugs.webkit.org/show_bug.cgi?id=48964
Attachment 72957: Moved the Android
setCookieStoragePrivateBrowsingEnabled(bool) stub to the WebCore namespace
https://bugs.webkit.org/attachment.cgi?id=72957&action=review
------- Additional Comments from Steve Block <steveblock at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72957&action=review
Did you track down the original offending change? Would be good to link to it
> WebCore/ChangeLog:9
> + a linker failure when building for Android. Moved the stub to the
WebCore namespace.
All WebCore changes need to mention how they're tested. In this case, 'No new
tests, build fix only' is sufficient
More information about the webkit-reviews
mailing list