[webkit-reviews] review granted: [Bug 45101] [GStreamer] ::buffered() should return multiple ranges in some cases : [Attachment 72950] proposed patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 45101: [GStreamer] ::buffered() should return multiple ranges in some cases
https://bugs.webkit.org/show_bug.cgi?id=45101

Attachment 72950: proposed patch
https://bugs.webkit.org/attachment.cgi?id=72950&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72950&action=review

Looks good overall. I'd just recommend doing the check for having exactly 2
buffered ranges, like we discussed on IRC.

> WebCore/platform/gtk/RenderThemeGtk.cpp:934
> +	       rangeRect.setLocation(IntPoint(trackRect.x() + (start /
mediaDuration)* totalWidth , trackRect.y()));

I believe you should not need the parens here, or else put the multiplication
inside it, any of them would make the code more obvious to me. Also, there's a
rogue space before the ',' =)