[webkit-reviews] review granted: [Bug 48515] [NRWT] Clear invalid http locks on Windows platform as well : [Attachment 72944] proposed_patch_v3

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Gabor Rapcsanyi
<rgabor at inf.u-szeged.hu>'s request for review:
Bug 48515: [NRWT] Clear invalid http locks on Windows platform as well
https://bugs.webkit.org/show_bug.cgi?id=48515

Attachment 72944: proposed_patch_v3
https://bugs.webkit.org/attachment.cgi?id=72944&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72944&action=review

This looks great!  Thank you!

We could break the windows check_running_pid out into a helper
_win32_check_running_pid() method since it's so long.  But it's also probably
OK for now as is.

> WebKitTools/Scripts/webkitpy/common/system/executive.py:252
> +

We should probably assert(false) here, since we're handling a case we dont'
expect.