[webkit-reviews] review granted: [Bug 48985] [Qt][WK2] Left over files and shared memory segments : [Attachment 72940] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 48985: [Qt][WK2] Left over files and shared memory segments
https://bugs.webkit.org/show_bug.cgi?id=48985

Attachment 72940: Patch
https://bugs.webkit.org/attachment.cgi?id=72940&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72940&action=review

r=me, three small things:

> WebKit2/Shared/qt/CrashHandler.cpp:30
> +#include <QCoreApplication>

Is this include needed?

> WebKit2/Shared/qt/CrashHandler.h:34
> +#include <QCoreApplication>

Is this include needed?

> WebKit2/Shared/qt/CrashHandler.h:74
> +#endif // CleanupHandler_h

#endif // CrashHandler_h

> WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:119
> +    // Do not leave socket files on the disk even on crash!
> +    CrashHandler::instance()->markForDeletionOnCrash(this);

This call is missing a corresponding didDelete() in ~ProcessLauncherHelper()