[webkit-reviews] review denied: [Bug 48505] Change Noncopyable macro to avoid using two subsequent line : [Attachment 72166] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 10:29:36 PDT 2010


Darin Adler <darin at apple.com> has denied Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 48505: Change Noncopyable macro to avoid using two subsequent line
https://bugs.webkit.org/show_bug.cgi?id=48505

Attachment 72166: proposed patch
https://bugs.webkit.org/attachment.cgi?id=72166&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This doesn’t seem like an improvement to me. Just seems a bit strange. If we
want to put things all on one line, we can do that without adding this unusual
feature to the macro.
 
    WTF_MAKE_NONCOPYABLE(Example); WTF_MAKE_FAST_ALLOCATED;

I suggest not making this change.


More information about the webkit-reviews mailing list