[webkit-reviews] review granted: [Bug 48770] [v8] Get rid of automatically generated named property getter for classes with namedItem method : [Attachment 72540] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted anton muhin
<antonm at chromium.org>'s request for review:
Bug 48770: [v8] Get rid of automatically generated named property getter for
classes with namedItem method
https://bugs.webkit.org/show_bug.cgi?id=48770

Attachment 72540: Patch
https://bugs.webkit.org/attachment.cgi?id=72540&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72540&action=review

> WebCore/bindings/scripts/CodeGeneratorV8.pm:1716
> -    my $hasGetter = $dataNode->extendedAttributes->{"HasNameGetter"} ||
$hasCustomGetter || $namedPropertyGetter;
> +    my $hasGetter = $dataNode->extendedAttributes->{"HasNameGetter"} ||
$hasCustomGetter;

If I am reading CodeGeneratorV8.pm correctly, $namedPropertyGetter is now
entirely unused.   If that is correct, please remove all other references to it
before landing.