[webkit-reviews] review denied: [Bug 48177] Expose |sendChangeEvent| parameter in WebInputElement::setValue() API : [Attachment 71631] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 1 13:09:28 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 48177: Expose |sendChangeEvent| parameter in WebInputElement::setValue()
API
https://bugs.webkit.org/show_bug.cgi?id=48177

Attachment 71631: Patch
https://bugs.webkit.org/attachment.cgi?id=71631&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71631&action=review

> WebKit/chromium/public/WebInputElement.h:70
> +	   WEBKIT_API void setValue(const WebString&, bool);

yes, please use a default argument.  also, please give this "bool" parameter a
name.


More information about the webkit-reviews mailing list