[webkit-reviews] review denied: [Bug 48264] new-run-webkit-tests: split out webkit-specific configuration stuff into a new module : [Attachment 71815] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 48264: new-run-webkit-tests: split out webkit-specific configuration stuff
into a new module
https://bugs.webkit.org/show_bug.cgi?id=48264

Attachment 71815: Patch
https://bugs.webkit.org/attachment.cgi?id=71815&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71815&action=review

I don't really understand this patch.  Seems to replicate functionality that
already exists in webkitpy but it doesn't remove that code, so we just end up
with more duplicate code.  Without seeing this code in use, it's difficult to
know whether this patch is an improvement or not.

> WebKitTools/Scripts/webkitpy/layout_tests/port/config.py:63
> +    _FLAGS_FROM_CONFIGURATIONS = {
> +	   "Debug": "--debug",
> +	   "Release": "--release",
> +    }

Surely this information exists in webkitpy already.  I don't see any minus
lines in this patch...