[webkit-reviews] review granted: [Bug 39822] Web Inspector: Implement additional tabs support in ResourceView : [Attachment 57467] [PATCH] Comments addressed

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 39822: Web Inspector: Implement additional tabs support in ResourceView
https://bugs.webkit.org/show_bug.cgi?id=39822

Attachment 57467: [PATCH] Comments addressed
https://bugs.webkit.org/attachment.cgi?id=57467&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/front-end/ResourceView.js:111
 +	    this.tabbedPane.hideTab("content");
Now that the tabbed pane is a component, you should simply not add content tab
in this case instead of adding and hiding it.

WebCore/inspector/front-end/SourceView.js:54
 +	    if (this.localSourceFrame)
I think what we should do is to come up with the tab factory for resources. So
that the factory was creating tabs of applicable types for each resource. As a
result, you would break SourceView -> ResourceView inheritance, will prevent
SourceView from being localSourceFrame-aware, will make local changes tab
absolutely separate extension, get rid of nasty show / hide headers when
SourceView is re-used in Scripts tab. Lots of goodness!