[webkit-reviews] review granted: [Bug 39957] Chromium: save inspector settings as dictionary, not as string. : [Attachment 57472] Proposed patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted  review:
Bug 39957: Chromium: save inspector settings as dictionary, not as string.
https://bugs.webkit.org/show_bug.cgi?id=39957

Attachment 57472: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=57472&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
r+ with nits.

WebKit/chromium/src/InspectorClientImpl.cpp:96
 +	m_inspectedWebView->inspectorSetting(key, &string);
So it did not compile for you with simply putting 'value' as a second argument?



WebKit/chromium/src/WebViewImpl.h:491
 +	typedef HashMap<WebCore::String, WebCore::String> SettingsMap;
WebKit should operate WebKit strings. I know it was wrong, but it may be a good
time to fix it.