[webkit-reviews] review denied: [Bug 38826] Don't convert filenames to URLs in edit drags. : [Attachment 56666] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 28 15:54:59 PDT 2010
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 38826: Don't convert filenames to URLs in edit drags.
https://bugs.webkit.org/show_bug.cgi?id=38826
Attachment 56666: Patch
https://bugs.webkit.org/attachment.cgi?id=56666&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> + String url = dragData->asURL(false, &title);
Boolean parameters suck. It's hard, at the call site, to know what the
true/false means. Either use an enum, or have two separate methods.
More information about the webkit-reviews
mailing list