[webkit-reviews] review granted: [Bug 33238] run-webkit-tests should catch control-C and offer to show you the failures/diffs so far : [Attachment 56771] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 33238: run-webkit-tests should catch control-C and offer to show you the
failures/diffs so far
https://bugs.webkit.org/show_bug.cgi?id=33238

Attachment 56771: Patch
https://bugs.webkit.org/attachment.cgi?id=56771&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
This is a great change.

WebKitTools/Scripts/webkitpy/layout_tests/layout_package/printing.py:290
 +		exp_str = str(expected)
Both these abbreviations are hard to read. incomplete_str and expected_str are
much more readable.

WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:765
 +		not self._retrying and not interrupted):
Nit: here and above, can you call this keyboard_interrupted? Makes it more
clear what this means without having to trace back to where this was set.