[webkit-reviews] review denied: [Bug 38844] [GTK] Add support for DOM events in the GObject DOM bindings : [Attachment 55698] testsignals.diff

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 38844: [GTK] Add support for DOM events in the GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=38844

Attachment 55698: testsignals.diff
https://bugs.webkit.org/attachment.cgi?id=55698&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 56	g_idle_add((GSourceFunc)finish_loading, fixture);
 57	g_main_loop_run(fixture->loop);

Why are you doing this here? I would expect the string to be loaded
synchronously, as it is now. Also, I think this test is lacking an assertion
that fixture->counter has been incremented at all. I don't think this test is
really testing what it's supposed to test, so I'll r-.