[webkit-reviews] review granted: [Bug 38844] [GTK] Add support for DOM events in the GObject DOM bindings : [Attachment 55690] signalnames.diff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 25 21:41:52 PDT 2010


Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 38844: [GTK] Add support for DOM events in the GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=38844

Attachment 55690: signalnames.diff
https://bugs.webkit.org/attachment.cgi?id=55690&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
WebCore/bindings/scripts/CodeGeneratorGObject.pm:494
 +	my ${listenerName} =  $domSignalName . "Listener";
there's an additional space that seems unnecessary here

Clever idea, the breakWords one.


More information about the webkit-reviews mailing list