[webkit-reviews] review granted: [Bug 38844] [GTK] Add support for DOM events in the GObject DOM bindings : [Attachment 55687] domevents.diff

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 38844: [GTK] Add support for DOM events in the GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=38844

Attachment 55687: domevents.diff
https://bugs.webkit.org/attachment.cgi?id=55687&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
WebCore/bindings/gobject/GObjectEventListener.h:31
 +	    static PassRefPtr<GObjectEventListener> create(GObject* object,
const char* signalName) { return adoptRef(new GObjectEventListener(object,
signalName)); }
Indentation looks weird here.

WebCore/bindings/gobject/GObjectEventListener.h:49
 +	virtual void handleEvent(ScriptExecutionContext*, Event*); /*  */
What's the /*  */ for? =)

WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:184
 +  
One too many empty lines here, for my taste.

A good first step IMO. And good improvement on style conformance, too.