[webkit-reviews] review denied: [Bug 36248] Implement lazy clearing of renderbuffers : [Attachment 56944] revised patch : responding to kbr's review

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Zhenyao Mo
<zmo at google.com>'s request for review:
Bug 36248: Implement lazy clearing of renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=36248

Attachment 56944: revised patch : responding to kbr's review
https://bugs.webkit.org/attachment.cgi?id=56944&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Just a few typos:

WebCore/ChangeLog:5
 +	    Implement lazy clearing of renderbuffers
Typo: implement.

WebCore/html/canvas/WebGLFramebuffer.cpp:134
 +	bool isSissorEnabled = false;
Typo: Scissor

WebCore/platform/graphics/mac/GraphicsContext3DMac.cpp:332
 +	GLboolean isSissorEnabled = GL_FALSE;
Ditto.


Another thing -- this is just a clarity suggestion. Would it be more
descriptive to define a simple Attachment abstraction, which holds
CanvasObject* and manages all casting and validity checking?