[webkit-reviews] review granted: [Bug 18595] REGRESSION (r20766): Setting display:none on an iframe causes the ownerDocument to freeze : [Attachment 56957] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 18595: REGRESSION (r20766): Setting display:none on an iframe causes the
ownerDocument to freeze
https://bugs.webkit.org/show_bug.cgi?id=18595

Attachment 56957: proposed fix
https://bugs.webkit.org/attachment.cgi?id=56957&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (m_capturingMouseEventsNode &&
(m_capturingMouseEventsNode->hasTagName(iframeTag) ||
m_capturingMouseEventsNode->hasTagName(frameTag)))

I think this would read a lot better with an isFrame-type helper function, even
if the implementation does the same hasTagName tests. What about objectTag?
Can't it contain subframes too?

r=me but please consider both comments