[webkit-reviews] review granted: [Bug 38845] Canvas color property getters should serialize them according to spec : [Attachment 56486] Proposed patch v9

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 19 07:43:42 PDT 2010


Darin Adler <darin at apple.com> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 38845: Canvas color property getters should serialize them according to
spec
https://bugs.webkit.org/show_bug.cgi?id=38845

Attachment 56486: Proposed patch v9
https://bugs.webkit.org/attachment.cgi?id=56486&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
If we don't need to allow null arguments to the CanvasStyle create functions,
we could remove the "return 0" code and just have an assertion instead. I can't
think of a good reason to have dead code for non-testable code paths.


More information about the webkit-reviews mailing list