[webkit-reviews] review granted: [Bug 39289] Wrong result in case of non-iterative matching of subpatterns in non-greedy cases in YARR Interpreter : [Attachment 56489] proposed patch v2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Peter Varga
<pvarga at inf.u-szeged.hu>'s request for review:
Bug 39289: Wrong result in case of non-iterative matching of subpatterns in
non-greedy cases in YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=39289

Attachment 56489: proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=56489&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -		       output[(subpatternId << 1) + 1] = input.getPos() +
term.inputPosition;
> +		       output[(subpatternId << 1)] = input.getPos() +
term.inputPosition;

I suggest omitting the parentheses here. output[subpatternId << 1] would be
easier to read.

> +	   The backtrackParentesesOnceEnd function should store the start
position

Typo here in the name of the function.