[webkit-reviews] review denied: [Bug 37804] [Qt] Image shadow doesn't work in Qt : [Attachment 56105] patch4

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied qi <qi.2.zhang at nokia.com>'s request
for review:
Bug 37804: [Qt] Image shadow doesn't work in Qt
https://bugs.webkit.org/show_bug.cgi?id=37804

Attachment 56105: patch4
https://bugs.webkit.org/attachment.cgi?id=56105&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
WebCore/platform/graphics/qt/ImageQt.cpp:194
 +	    FloatRect shadowM(dst);
This name is not the best choice. How about shadowImageRect?

WebCore/platform/graphics/qt/ImageQt.cpp:198
 +	    QPainter p(&shadowImage);
Isn't a bit expansive to create a new Image, create a new context of this
image, set the compositing, take the original image draw it into the context of
the shadowImage and draw this shadowImage to the real painter?

Isn't it better, to save the current composite operator of painter, make the
drawing directly on the painter (without a intermediate image) and set the
comp-op of the painter back?