[webkit-reviews] review granted: [Bug 38711] DragData::asURL() shouldn't do file validity checks : [Attachment 56326] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 18 09:34:32 PDT 2010


Darin Adler <darin at apple.com> has granted Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 38711: DragData::asURL() shouldn't do file validity checks
https://bugs.webkit.org/show_bug.cgi?id=38711

Attachment 56326: Patch
https://bugs.webkit.org/attachment.cgi?id=56326&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   // The loader will do the right thing if the filename is invalid for
one reason or another.
> +	   url = ChromiumBridge::filePathToURL(fileName).string();

I think the reference to "the loader" here is confusing and unnecessary. The
comment is more about the old code than it is about the code that remains and
could be omitted entirely.


More information about the webkit-reviews mailing list