[webkit-reviews] review denied: [Bug 39237] Web Inspector: keyboard shortcut screen does not disappear on Esc. : [Attachment 56377] patch: maintain focus on help screen while it's shown

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 39237: Web Inspector: keyboard shortcut screen does not disappear on Esc.
https://bugs.webkit.org/show_bug.cgi?id=39237

Attachment 56377: patch: maintain focus on help screen while it's shown
https://bugs.webkit.org/attachment.cgi?id=56377&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
WebCore/inspector/front-end/HelpScreen.js:44
 +	this.contentElement.addEventListener("blur", this._onBlur.bind(this),
false);
You should register this in show and _hide so there isn't always a listener,
even if help is never used.

WebCore/inspector/front-end/HelpScreen.js:87
 +	    if (this._isShown)
Then you wouldn't need to check this, since you know it was visible or your
wouldn't have been called.

Otherwise r+.