[webkit-reviews] review requested: [Bug 39237] Web Inspector: keyboard shortcut screen does not disappear on Esc. : [Attachment 56377] patch: maintain focus on help screen while it's shown

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 18 08:23:55 PDT 2010


Andrey Kosyakov <caseq at chromium.org> has asked	for review:
Bug 39237: Web Inspector: keyboard shortcut screen does not disappear on Esc.
https://bugs.webkit.org/show_bug.cgi?id=39237

Attachment 56377: patch: maintain focus on help screen while it's shown
https://bugs.webkit.org/attachment.cgi?id=56377&action=review

------- Additional Comments from Andrey Kosyakov <caseq at chromium.org>
This is obviously because we loose focus. I fixed it, but there are some
caveats:
- It doesn't work vice-versa (when transitioning for undocked to docked state),
as entire inspector window gets out of focus. One would need to click it to get
it focused again. This should probably be fixed in the browsers.
- Text edit fields commit edited changes upon loosing focus. I hesitated
whether we should disable our help when inspector is in editing mode, but then
realized we only use shortcuts that would cause browser help to be opened, so
we'll loose editor focus and commit changes anyway.


More information about the webkit-reviews mailing list