[webkit-reviews] review granted: [Bug 39252] Move host/native JSFunction's NativeFunction onto NativeExecutable. : [Attachment 56302] Fix WebCore build.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 17 19:31:38 PDT 2010


Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 39252: Move host/native JSFunction's NativeFunction onto NativeExecutable.
https://bugs.webkit.org/show_bug.cgi?id=39252

Attachment 56302: Fix WebCore build.
https://bugs.webkit.org/attachment.cgi?id=56302&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

Looks like JSLazyEventListener may need to #include JSFunction.h, or something:


../../WebCore/bindings/js/JSLazyEventListener.cpp: In member function ‘virtual
JSC::JSObject*
WebCore::JSLazyEventListener::initializeJSFunction(WebCore::ScriptExecutionCont
ext*) const’:
../../WebCore/bindings/js/JSLazyEventListener.cpp:125: error: ‘class
JSC::JSFunction’ has no member named ‘setScope’
make[1]: *** [WebCore/bindings/js/libwebkit_1_0_la-JSLazyEventListener.lo]
Error 1


More information about the webkit-reviews mailing list