[webkit-reviews] review granted: [Bug 39257] Chromium: new-run-webkit-httpd fails to setup_mount : [Attachment 56306] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 17 19:11:26 PDT 2010
Eric Seidel <eric at webkit.org> has granted Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 39257: Chromium: new-run-webkit-httpd fails to setup_mount
https://bugs.webkit.org/show_bug.cgi?id=39257
Attachment 56306: Patch
https://bugs.webkit.org/attachment.cgi?id=56306&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM. A unit test would be even better. There is a MockExecutive inside
mocktool.py which knows how to log arguments. outputcapture.py can be used to
assert that the right output was logged.
More information about the webkit-reviews
mailing list