[webkit-reviews] review denied: [Bug 39157] FrameLoader: refactor FrameLoader::isDocumentSandboxed() to be a non-member, non-friend function : [Attachment 56180] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 39157: FrameLoader: refactor FrameLoader::isDocumentSandboxed() to be a
non-member, non-friend function
https://bugs.webkit.org/show_bug.cgi?id=39157

Attachment 56180: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=56180&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great.  One nit:

WebCore/loader/FrameLoader.cpp:178
 +  static bool isDocumentSandboxed(const Frame& frame, SandboxFlags mask)
We pass Frame by Frame* and not by const Frame&.  It's probably better to be
consistent about that.