[webkit-reviews] review denied: [Bug 38827] FrameLoader: refactor changeLocation() and urlSelected() to share more code : [Attachment 55954] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 38827: FrameLoader: refactor changeLocation() and urlSelected() to share
more code
https://bugs.webkit.org/show_bug.cgi?id=38827

Attachment 55954: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=55954&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
For parameters like shouldReplaceDocumentIfJavascriptURL, we like to use enums
with two values so you can read at the call site what the parameter does
(instead of just "true" or "false").  For example, we'd add
ReplaceDocumentIfJavaScritptURL or DoNotReplaceDocumentIfJavaScritptURL as the
argument.