[webkit-reviews] review granted: [Bug 34005] Safari pegs CPU and drops tons of frames using HTML5 Vimeo player : [Attachment 55149] Part 1.1: QTMovieWin: The breakup of QTMovieWin

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 34005: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
https://bugs.webkit.org/show_bug.cgi?id=34005

Attachment 55149: Part 1.1: QTMovieWin: The breakup of QTMovieWin
https://bugs.webkit.org/attachment.cgi?id=55149&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
>	       if (shouldRestorePlaybackState && m_timeToRestore != -1.0f) {
>		   m_movieWin->setCurrentTime(m_timeToRestore);
> @@ -281,7 +190,7 @@ void QTMovieWinPrivate::task()
>		   m_rateToRestore = -1.0f;
>	       }

I know you didn't add this, but as long as you are cleaning things up you might
as well change "-1.0f" to "-1" to match style guidelines.


> +    size_t indexOfClient = m_private->m_clients.find(client);
> +    if (indexOfClient >= 0)
> +	   m_private->m_clients.remove(indexOfClient);

Is ever this OK for this search to fail? If not, add an ASSERT() so we can
track down the source of the problem.

Nice refactoring!

r=me