[webkit-reviews] review denied: [Bug 37798] svg/custom/use-instanceRoot-as-event-target.xhtml crashes randomly : [Attachment 55368] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 37798: svg/custom/use-instanceRoot-as-event-target.xhtml crashes randomly
https://bugs.webkit.org/show_bug.cgi?id=37798

Attachment 55368: Patch
https://bugs.webkit.org/attachment.cgi?id=55368&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/ChangeLog:14
 +	    it, but residing in the correspondingElement() event listener list
(and thus existant!).
The last sentence isn't entirely english.  registrated and existant aren't
words.

WebCore/svg/SVGElementInstance.cpp:92
 +	if (!element || !element->document())
I can never remember if this is the right ->document() pointer or
ownerDocument().  Should this be element->inDocument()?

WebCore/svg/SVGElementInstance.cpp:150
 +	ASSERT_NOT_REACHED();
Seems we should add comments in teh code to explain *why* these are
ASSERT_NOT_REACHED()

LayoutTests/ChangeLog:8
 +	    Make use-instanceRoot-as-event-target.xhtml behave more correctly.
Due a copy&paste problem test #7 was not executed. Fixed.
copy & paste

Seems we need TestObject.idl changes to correspond with your codegenerator
changes.

Otherwise this looks fantastic!