[webkit-reviews] review granted: [Bug 38724] svn-apply: Refactor VCSUtil.pm's parse methods to use "not set" rather than "undef" : [Attachment 55373] Proposed patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 38724: svn-apply: Refactor VCSUtil.pm's parse methods to use "not set"
rather than "undef"
https://bugs.webkit.org/show_bug.cgi?id=38724

Attachment 55373: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=55373&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
> @@ -456,7 +457,7 @@ sub parseGitDiffHeader($$)
>  
>      my $copiedFromPath;
>      my $foundHeaderEnding;
> -    my $isBinary;
> +    my $isBinary = 0;

>From my understanding, we can leave this as "my $isBinary;" based on your usage
in:

$header{isBinary} = $isBinary if $isBinary;

> @@ -550,7 +552,7 @@ sub parseSvnDiffHeader($$)
>      my $copiedFromPath;
>      my $foundHeaderEnding;
>      my $indexPath;
> -    my $isBinary;
> +    my $isBinary = 0;

Similarly, we can leave this as "my $isBinary;";

> @@ -640,8 +642,8 @@ sub parseDiffHeader($$)
>      my ($fileHandle, $line) = @_;
>  
>      my $header;  # This is a hash ref.
> -    my $isGit;
> -    my $isSvn;
> +    my $isGit = 0;
> +    my $isSvn = 0;

Similarly, we can leave these as:

my $isGit;
my $isSvn;

r=me.