[webkit-reviews] review granted: [Bug 38740] Web Inspector: On Linux/Windows panel history is traversed while iterating over words in text prompt. : [Attachment 55362] [PATCH] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 08:13:30 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 38740: Web Inspector: On Linux/Windows panel history is traversed while
iterating over words in text prompt.
https://bugs.webkit.org/show_bug.cgi?id=38740

Attachment 55362: [PATCH] Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=55362&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index e498aa5..a279f5a 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,16 @@
> +2010-05-07  Pavel Feldman  <pfeldman at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Web Inspector: On Linux/Windows panel history is traversed while
iterating over words in text prompt.
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=38740
> +
> +	   * inspector/front-end/TextPrompt.js:
> +	   (WebInspector.TextPrompt):
> +	   * inspector/front-end/inspector.js:
> +	   (WebInspector.documentKeyDown):
> +

NIT: ChangeLog could include an explanation about why this didn't work.

Thanks for catching this.


More information about the webkit-reviews mailing list