[webkit-reviews] review granted: [Bug 38320] svn-apply: Add an "isBinary" property to the hashes returned by parseDiff() and parseDiffHeader() : [Attachment 55153] Proposed patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 38320: svn-apply: Add an "isBinary" property to the hashes returned by
parseDiff() and parseDiffHeader()
https://bugs.webkit.org/show_bug.cgi?id=38320

Attachment 55153: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=55153&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Looks good to me.

By the way, I've noticed that we interchange between "SVN", "Svn", and "svn"
throughout VCSUtils. Similarly, we interchange between "git" and "Git". We
should consider standardizing around one. This does not need to be addressed in
this patch, just wanted to point it out.