[webkit-reviews] review denied: [Bug 38609] Expose FileReader interface : [Attachment 55331] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 6 19:20:38 PDT 2010
Dmitry Titov <dimich at chromium.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 38609: Expose FileReader interface
https://bugs.webkit.org/show_bug.cgi?id=38609
Attachment 55331: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=55331&action=review
------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Looks great.
One thing - could you please organize the output of the test in such a way as
to avoid the file-reader-expected.txt to be a binary file? If it is binary, it
will be harder to see in various tools what will change in subsequent changes.
Also, it'd be cool if the patch could pass EWS, less potential troubles this
way.
r- to consider the expected file format.
More information about the webkit-reviews
mailing list