[webkit-reviews] review denied: [Bug 31407] [PATCH] [Qt] Compilation with Plugins disabled is broken : [Attachment 54418] Patch to fix compilation problem with plugins disabled.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 5 14:22:59 PDT 2010


Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Ismail "cartman" Donmez
<ismail at namtrac.org>'s request for review:
Bug 31407: [PATCH] [Qt] Compilation with Plugins disabled is broken
https://bugs.webkit.org/show_bug.cgi?id=31407

Attachment 54418: Patch to fix compilation problem with plugins disabled.
https://bugs.webkit.org/attachment.cgi?id=54418&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
This patch implements 3 stub functions for WINCE. I found two issues that
should be looked into:

1./ WebCore/platform/qt/TemporaryLinkStubs.cpp implements these stubs for
WINCE. How come they are not working ? 

2./ The proposed patch would break (for example) the SYMBIAN build if
NETSCAPE_PLUGIN_API=1 (as the 3 symbols would be defined twice - see
PluginDatabaseSymbian.cpp).


More information about the webkit-reviews mailing list