[webkit-reviews] review granted: [Bug 38604] workers-gc2 crashing on Qt : [Attachment 55150] The patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 38604: workers-gc2 crashing on Qt
https://bugs.webkit.org/show_bug.cgi?id=38604

Attachment 55150: The patch
https://bugs.webkit.org/attachment.cgi?id=55150&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   on AtomicStrings – it implicitly assumes that all AtomicStrings
have already

You should stick to ASCII for ChangeLog.

> +    void setIsAtomic(bool isIdentifier)
> +    {
> +	   ASSERT(!isStatic());
> +	   if (isIdentifier)
> +	       m_refCountAndFlags |= s_refCountFlagIsAtomic;
> +	   else
> +	       m_refCountAndFlags &= s_refCountFlagIsAtomic;
> +    }

Maybe a set/clear pair of functions instead of one that takes a bool would be
better.