[webkit-reviews] review granted: [Bug 38589] [chromium] Add quota parameter to WebStorageNamespace::createSessionStorageNamespace : [Attachment 55133] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted hans at chromium.org's request for
review:
Bug 38589: [chromium] Add quota parameter to 
WebStorageNamespace::createSessionStorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=38589

Attachment 55133: Patch
https://bugs.webkit.org/attachment.cgi?id=55133&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Please fix and upload another patch.  I'll commit queue + that one (so it'll
get committed to WebKit).


> diff --git a/WebKit/chromium/ChangeL
>      // If path is empty, data will not persist. You should call delete on
the returned
>      // object when you're finished.
>      WEBKIT_API static WebStorageNamespace* createLocalStorageNamespace(const
WebString& backingDirectoryPath, unsigned quota);
> -    WEBKIT_API static WebStorageNamespace* createSessionStorageNamespace();
> +

Don't need this newline.

> +    WEBKIT_API static WebStorageNamespace*
createSessionStorageNamespace(unsigned quota);
> +

Don't need this new lines.