[webkit-reviews] review denied: [Bug 38146] document.write is not synchronous after page load : [Attachment 54935] [PATCH] Fixed a Few Style Issues

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 38146: document.write is not synchronous after page load
https://bugs.webkit.org/show_bug.cgi?id=38146

Attachment 54935: [PATCH] Fixed a Few Style Issues
https://bugs.webkit.org/attachment.cgi?id=54935&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/dom/Document.cpp:1963
 +	HTMLTokenizer* htmlTokenizer = (m_tokenizer->isHTMLTokenizer() ?
static_cast<HTMLTokenizer*>(m_tokenizer.get()) : 0);
No outer parenthesis needed.

WebCore/dom/Document.cpp:1963
 +	HTMLTokenizer* htmlTokenizer = (m_tokenizer->isHTMLTokenizer() ?
static_cast<HTMLTokenizer*>(m_tokenizer.get()) : 0);
This seems like it should be an asHTMLTokenzer method of m_tokenizer.  Does
this pattern occur elsewhere in this file?  RTTI is usually a bad idea.

WebCore/dom/Document.cpp:1972
 +	    htmlTokenizer->setForceSynchronous(savedForceSynchronous);
Can we do this with a RAII class?  The implementation you have is error prone.