[webkit-reviews] review granted: [Bug 38262] check-webkit-style: Rename CppProcessor to CppChecker, etc : [Attachment 54564] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 3 14:29:06 PDT 2010


Eric Seidel <eric at webkit.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 38262: check-webkit-style: Rename CppProcessor to CppChecker, etc
https://bugs.webkit.org/show_bug.cgi?id=38262

Attachment 54564: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=54564&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not sure I really understand the distinction, so all you really get is a
rubber-stamp.  Why changing all this to checker, instead of the other way
around?  Seems processor is about as meaningless as checker so I would probably
optimize for minimal renames.

But honestly, I have really no opinions about any of this.

Do we have any need to be able to merge any of this code with anyone?


More information about the webkit-reviews mailing list