[webkit-reviews] review granted: [Bug 38486] Maui MiniBrowser: Add an option to show/hide the web view : [Attachment 54960] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 38486: Maui MiniBrowser: Add an option to show/hide the web view
https://bugs.webkit.org/show_bug.cgi?id=38486

Attachment 54960: Patch
https://bugs.webkit.org/attachment.cgi?id=54960&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   * MiniBrowser/win/BrowserWindow.cpp:
> +	   (BrowserWindow::createWindow):
> +	   (BrowserWindow::onCommand):
> +	   * MiniBrowser/win/MiniBrowser.rc:
> +	   * MiniBrowser/win/resource.h:

More details, please!

> +    case ID_DEBUG_SHOW_WEB_VIEW: {
> +	   HMENU menu = ::GetMenu(m_window);
> +	   bool isChecked = ::GetMenuState(menu, ID_DEBUG_SHOW_WEB_VIEW,
MF_BYCOMMAND) & MF_CHECKED;

I would call this variable shouldHide. Or reverse it and call it shouldShow.

r=me