[webkit-reviews] review requested: [Bug 36902] [Qt] Patch to allow java applet support through QWebPluginFactory... : [Attachment 52210] Java applet support through QWebPluginFactory::create I

[bugzilla-daemon at webkit.org]

adawit at kde.org has asked  for review:
Bug 36902: [Qt] Patch to allow java applet support through QWebPluginFactory...
https://bugs.webkit.org/show_bug.cgi?id=36902

Attachment 52210: Java applet support through QWebPluginFactory::create I
https://bugs.webkit.org/attachment.cgi?id=52210&action=review

------- Additional Comments from adawit at kde.org
Currently java applet support is not implemented in QtWebKit. Additionally the
request to create a JavaApplet widget simply calls notImplemented() and returns
a NULL. See the "createJavaAppletWidget" function under
WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp. Unfortunately, this makes it
impossible for client level applications to provide their own Java applet
support by re-implementing QWebPluginFactory like they can for other plugins
such as flash. The attached patch attempts to address this issue by simply
making it possible for client applications to handle java applets through
QWebPluginFactory::create(...) function.