[webkit-reviews] review granted: [Bug 36472] Add support to create UUID string. : [Attachment 52200] Proposed Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 36472: Add support to create UUID string.
https://bugs.webkit.org/show_bug.cgi?id=36472

Attachment 52200: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=52200&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
r=me

One note, please consider while landing:

> +#elif OS(LINUX)
> +    FILE* fptr = fopen("/proc/sys/kernel/random/uuid", "r");
> +    if (!fptr)
> +	   return String();
> +    char uuidStr[37] = {0};
> +    fgets(uuidStr, sizeof(uuidStr) - 1, fptr);
> +    fclose(fptr);
> +    return String(uuidStr);

If we do want the lowercase only, it probably makes sense to return .lower()
here as well. Unless we have a guarantee that all Linux flavors return
lowercase already.