[webkit-reviews] review granted: [Bug 36771] new-run-webkit-tests shouldn't report "unexpected passes" when pixel tests are disabled : [Attachment 51996] update after more feedback from eseidel

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 36771: new-run-webkit-tests shouldn't report "unexpected passes" when pixel
tests are disabled
https://bugs.webkit.org/show_bug.cgi?id=36771

Attachment 51996: update after more feedback from eseidel
https://bugs.webkit.org/attachment.cgi?id=51996&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You compute "test_is_skipped" here but never use it?
 165	     test_is_skipped = self._expected_failures.has_modifier(test, SKIP)


I don't really understand the use of the name "t", "m" and "f".  I don't think
they add to readability being so short.

In general this looks great and much cleaner than before.  Thank you for
workign through it again.

r=me.  Please fix some subset of the above nits when you go to land it.  No
need to post it again.