[webkit-reviews] review granted: [Bug 36897] REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com) : [Attachment 52197] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 31 12:42:57 PDT 2010


mitz at webkit.org has granted Alexey Proskuryakov <ap at webkit.org>'s request for
review:
Bug 36897: REGRESSION (r56429): Flash ads are clipped when main page is
scrolled (boxofficemojo.com)
https://bugs.webkit.org/show_bug.cgi?id=36897

Attachment 52197: proposed fix
https://bugs.webkit.org/attachment.cgi?id=52197&action=review

------- Additional Comments from mitz at webkit.org
Thanks for fixing this!

> +    IntRect m_clipRect; // The rectangle needs to remain correct after
scrolling, so storing it in frame view coordinates, and not clipped to window.

I would say “content view coordinates”.

r=me


More information about the webkit-reviews mailing list