[webkit-reviews] review canceled: [Bug 36724] Add support for <ol reversed> : [Attachment 51970] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 30 13:38:24 PDT 2010


Jakub Wieczorek <jwieczorek at webkit.org> has canceled Jakub Wieczorek
<jwieczorek at webkit.org>'s request for review:
Bug 36724: Add support for <ol reversed>
https://bugs.webkit.org/show_bug.cgi?id=36724

Attachment 51970: patch
https://bugs.webkit.org/attachment.cgi?id=51970&action=review

------- Additional Comments from Jakub Wieczorek <jwieczorek at webkit.org>
> You could take a look at the mechanisms that NodeList uses to keep its lists
up
> to date. The requirements of a TagNodeList are quite similar to what a list
> would need to do to keep track of its list items. The functions
> notifyNodeListsAttributeChanged and notifyNodeListsChildrenChanged are part
of
> what makes node lists work.
>
> We may need to do more of this on the render tree side instead of the DOM
tree.
> An element with "display: list-item" contributes to list numbering too. In
> fact, I think that may be something wrong with the current code and patch. We

> need some test cases that use CSS to create list items or to turn list items
> into non-list-item content.

Great, thanks for the hints!

Clearing the review flag for now.


More information about the webkit-reviews mailing list