[webkit-reviews] review granted: [Bug 36848] Menu items appropriate only for rich-content editing can appear in plain-text contexts : [Attachment 52075] Patch that does returns self for non-string content only if _canEditRichly is true

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted John Sullivan <sullivan at apple.com>'s request for
review:
Bug 36848: Menu items appropriate only for rich-content editing can appear in
plain-text contexts
https://bugs.webkit.org/show_bug.cgi?id=36848

Attachment 52075: Patch that does returns self for non-string content only if
_canEditRichly is true
https://bugs.webkit.org/attachment.cgi?id=52075&action=review

------- Additional Comments from mitz at webkit.org
> Index: WebKit/mac/ChangeLog
> ===================================================================
> --- WebKit/mac/ChangeLog	(revision 56805)
> +++ WebKit/mac/ChangeLog	(working copy)
> @@ -1,3 +1,15 @@
> +2010-03-30  John Sullivan  <sullivan at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=36848
> +	   <rdar://problem/7362913>
> +	   Menu items appropriate only for rich-content editing can appear in
plain-text contexts
> +
> +	   * WebView/WebHTMLView.mm:
> +	   (-[WebHTMLView validRequestorForSendType:returnType:]):
> +	   Don't return self for non-string content if _canEditRichly is false.

> +
>  2010-03-29  Alexey Proskuryakov  <ap at apple.com>
>  
>	   Reviewed by Darin Adler.
> Index: WebKit/mac/WebView/WebHTMLView.mm
> ===================================================================
> --- WebKit/mac/WebView/WebHTMLView.mm (revision 56664)
> +++ WebKit/mac/WebView/WebHTMLView.mm (working copy)
> @@ -2539,7 +2539,13 @@ - (BOOL)readSelectionFromPasteboard:(NSP
>  - (id)validRequestorForSendType:(NSString *)sendType returnType:(NSString
*)returnType
>  {
>      BOOL isSendTypeOK = !sendType || ([[self pasteboardTypesForSelection]
containsObject:sendType] && [self _hasSelection]);
> -    BOOL isReturnTypeOK = !returnType || ([[[self class]
_insertablePasteboardTypes] containsObject:returnType] && [self _isEditable]);
> +	   BOOL isReturnTypeOK = NO;
> +    if (!returnType)

Weird indentation.