[webkit-reviews] review canceled: [Bug 36664] Add animation to progress element : [Attachment 52030] Adress Antti's comments in #4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 30 12:26:28 PDT 2010


Yael <yael.aharon at nokia.com> has canceled Yael <yael.aharon at nokia.com>'s
request for review:
Bug 36664: Add animation to progress element
https://bugs.webkit.org/show_bug.cgi?id=36664

Attachment 52030: Adress Antti's comments in #4
https://bugs.webkit.org/attachment.cgi?id=52030&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Update the design as siggested on IRC (comment #6).
Some changes 
- Renamed startAnimation() to updateAnimationState() because it is not starting
the animation timer anymore.
- Removed the check RenderObject::willRenderContents() because when a page is
in the b/f cache, paint() is not called, so the timer will not start.


More information about the webkit-reviews mailing list