[webkit-reviews] review denied: [Bug 36245] Add option "target" to rebaseline_chromium_webkit_test.py : [Attachment 52065] Proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Victor Wang <victorw at chromium.org>'s
request for review:
Bug 36245: Add option "target" to rebaseline_chromium_webkit_test.py
https://bugs.webkit.org/show_bug.cgi?id=36245

Attachment 52065: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=52065&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why is this special-cased for release?	And why would this sort of logic go on
the port object itself?  Seems that the port object already does this sort of
check it just does it in one big method.  We could easily break out the image
diff part of that check into a separate method callable from here.  The goal is
easy code re-use, and this doesn't look very re-useable as-is.