[webkit-reviews] review denied: [Bug 36529] [Qt] Compilation error on Qt for Embedded Linux built with -qconfig medium : [Attachment 51494] add #ifndef QT_NO_TEXTCODEC ~ #endif

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Tasuku Suzuki
<tasuku.suzuki at nokia.com>'s request for review:
Bug 36529: [Qt] Compilation error on Qt for Embedded Linux built with -qconfig
medium
https://bugs.webkit.org/show_bug.cgi?id=36529

Attachment 51494: add #ifndef QT_NO_TEXTCODEC ~ #endif
https://bugs.webkit.org/attachment.cgi?id=51494&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
The patch itself is fine, but I don't think we should add these defines, as
WebKit cannot be used without codecs. Therefore the right thing to do is to
disable the compilation of WebKit altogether if Qt is compiled with
QT_NO_TEXTCODEC.