[webkit-reviews] review granted: [Bug 36481] Web Inspector: Edit Tag Names : [Attachment 51852] [PATCH] Part 2 - Fix Tabbing and Attribute Editing

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 36481: Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481

Attachment 51852: [PATCH] Part 2 - Fix Tabbing and Attribute Editing
https://bugs.webkit.org/attachment.cgi?id=51852&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +	       var previous = element.previousSibling;
> +	       if (!previous || previous.nodeType !== Node.TEXT_NODE)
> +		   element.parentNode.insertBefore(document.createTextNode("
"), element);
> +	       element.outerHTML = "<span class=\"webkit-html-attribute\">" +
> +				     "<span
class=\"webkit-html-attribute-name\">" + attr.name.escapeHTML() +
"</span>=&#8203;\"" +
> +				     "<span
class=\"webkit-html-attribute-value\">" + attr.value.escapeHTML() +
"</span>&#8203;\"" +
> +				   "</span>";

I really don't like these snippets spread all over the code in various methods.
We really should do it in single place!